Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
localhost lost as a builtin cloud from cmd. #7039
Conversation
| +// regardless of whether it's public, private or builtin cloud. | ||
| +// Since this method caters for builtin clouds, unlike cloud.CloudByName, | ||
| +// it should be used in cmd. | ||
| +func AnyCloudByName(cloudName string) (*jujucloud.Cloud, error) { |
axw
Feb 27, 2017
Member
can this just be called "CloudByName"? the "Any" prefix doesn't explain the difference between this and cloud.CloudByName, so may as well not be there
anastasiamac
Feb 27, 2017
Member
It could but I did not want people to confuse it with cloud.CloudByName and wanted to make it absolutely, positively, blatantly obvious that one has a limitation over the other, especially when called from commands...
I am not too attached to the name if you insist though :D
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 3a372fe
into
juju:develop
Feb 27, 2017
anastasiamac
deleted the
anastasiamac:cmd-lost-localhost
branch
Feb 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
anastasiamac commentedFeb 27, 2017
Description of change
Juju caters for 3 categories of clouds - public, private and built-in. Some command could not recognise built-in clouds.
QA steps
SCENARIO 1: interactively bootstrap with a built-in cloud
SCENARIO 2: List regions for a built-in cloud
Documentation changes
n/a
Bug reference
https://bugs.launchpad.net/juju/+bug/1665056