/juju

Check provided auth type is valid for the cloud. #7040

Merged
merged 3 commits into from Feb 27, 2017

Conversation

Reviewers

@axw axw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@anastasiamac @jujubot @axw
@anastasiamac
Member

anastasiamac commented Feb 27, 2017

Description of change

When adding credentials, provided auth types need to be valid for a given cloud.

QA steps

  1. add cloud with some auth type
  2. add credential using -f where file contains either mistyped or an auth type not listed for the cloud
  3. Add cloud command should error out.

Bug reference

https://bugs.launchpad.net/juju/+bug/1590239
@axw

axw approved these changes Feb 27, 2017
View changes

@anastasiamac
Member

anastasiamac commented Feb 27, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Feb 27, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Feb 27, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10374
@anastasiamac
Member

anastasiamac commented Feb 27, 2017

!!build!!
@anastasiamac
Member

anastasiamac commented Feb 27, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Feb 27, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 82a819c into juju:develop Feb 27, 2017

@anastasiamac anastasiamac deleted the anastasiamac:check-auths-import-1590239 branch Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment