Concrete testing shows that its actually UnexpectedError. #7048

Merged
merged 1 commit into from Mar 1, 2017

Conversation

Projects
None yet
2 participants
Owner

jameinel commented Feb 28, 2017

The content of the error is a ServerError with the values we were
checking, but it has been wrapped in an UnexpectedError which doesn't
seem to make the original error available.

Description of change

MAAS 2.0 doesn't support static-routes, and I misunderstood the error we were getting. We get a ServerError wrapped by a UnexpectedError, and errors.Wrap doesn't let you get to the original error.

QA steps

Against a MAAS 2.0 controller:

  $ juju bootstrap
  $ juju switch controller
  $ juju add-machine lxd:0
  $ juju status
  $ juju ssh 0/lxd/0

Without this patch we get an error and the 'fallback to lxdbr0' code kicks in and you get an unreachable container.

Documentation changes

No, as 2.1 didn't ship with this bug.

Bug reference

lp:1668359

Concrete testing shows that its actually UnexpectedError.
The content of the error is a ServerError with the values we were
checking, but it has been wrapped in an UnexpectedError which doesn't
seem to make the original error available.
Owner

jameinel commented Feb 28, 2017

$$merge$$ since I tested it live

Contributor

jujubot commented Feb 28, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Feb 28, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10384

Owner

jameinel commented Mar 1, 2017

$$merge$$ the failure was "euca service not available at this time", doesn't seem like my fault.

Contributor

jujubot commented Mar 1, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 69fd0d6 into juju:2.1 Mar 1, 2017

1 check failed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details

@jameinel jameinel deleted the jameinel:2.1.1-no-maas-2.0-static-routes-1668359 branch Apr 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment