Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Include remote applications in model dump #7049
Conversation
babbageclunk
added some commits
Feb 23, 2017
|
!!build!! |
| @@ -53,6 +53,10 @@ func (st *State) Import(model description.Model) (_ *Model, _ *State, err error) | ||
| return nil, nil, errors.Trace(err) | ||
| } | ||
| + if len(model.RemoteApplications()) != 0 { | ||
| + return nil, nil, errors.New("can't import models with remote applications") |
wallyworld
Feb 28, 2017
Owner
could you add a comment here saying why - that CMR is currently limited to models on the one controller
| @@ -1118,6 +1118,47 @@ func (s *MigrationImportSuite) TestPayloads(c *gc.C) { | ||
| c.Check(payload.Machine, gc.Equals, machineID) | ||
| } | ||
| +func (s *MigrationImportSuite) TestRemoteApplications(c *gc.C) { | ||
| + // For now we want to prevent importing models that have remote |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 1a5f8bb
into
juju:develop
Feb 28, 2017
babbageclunk
deleted the
babbageclunk:dump-remote-apps-split
branch
Mar 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
babbageclunk commentedFeb 28, 2017
Description of change
This means that we can see remote applications in the dump-model output. At the moment we don't support importing models with remote applications - that requires a lot of other changes to work correctly.
Uses the new RemoteApplication and RemoteEndpoint added to the description in juju/description#1
QA steps
juju dump-modelon each model and verify that the YAML includes the remote application information.