/juju

[api test] Wait longer for messages #7058

Merged
merged 1 commit into from Mar 2, 2017

Conversation

Reviewers

@babbageclunk babbageclunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@howbazaar @jujubot @babbageclunk
@howbazaar
Owner

howbazaar commented Mar 2, 2017

Description of change

https://bugs.launchpad.net/juju/+bug/1669209 indicates that sometimes on windows 50ms is not long enough to wait for the messages to flow. Setting the max time to wait to LongWait. Since those timeouts indicate general failure, and are backstops, this will not slow down any successful test runs.

QA steps

go test ./...

Documentation changes

No change.

Bug reference

https://bugs.launchpad.net/juju/+bug/1669209

@howbazaar howbazaar changed the base branch from staging to develop Mar 2, 2017

@babbageclunk

babbageclunk approved these changes Mar 2, 2017
View changes

Looks good - since those timeouts aren't expected to happen they should be LongWait.

@howbazaar
Owner

howbazaar commented Mar 2, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Mar 2, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit d9ccffa into juju:develop Mar 2, 2017

@howbazaar howbazaar deleted the howbazaar:pubsub-longer-wait branch Mar 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment