worker: use external worker package #7070

Merged
merged 1 commit into from Mar 8, 2017

Conversation

Projects
None yet
3 participants
Owner

rogpeppe commented Mar 6, 2017

The package gopkg.in/worker.v1 has existed for a while
and will soon have some changes that we need in Juju,
so use it instead of the locally defined Runner type
and delete that.

Also sort the imports canonically throughout.
Although large, there are no significant semantic
changes introduced by this PR.

mjs approved these changes Mar 7, 2017

Thank you!

@@ -11,10 +11,10 @@ import (
"github.com/juju/testing"
jc "github.com/juju/testing/checkers"
gc "gopkg.in/check.v1"
+ worker "gopkg.in/juju/worker.v1"
@mjs

mjs Mar 7, 2017

Contributor

Why the alias? (similarly below)

@rogpeppe

rogpeppe Mar 7, 2017

Owner

That's what goimports does by default, and who am I to argue?

Owner

rogpeppe commented Mar 7, 2017

$$merge$$

Contributor

jujubot commented Mar 7, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Mar 7, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10420

worker: use external worker package
The package gopkg.in/worker.v1 has existed for a while
and will soon have some changes that we need in Juju,
so use it instead of the locally defined Runner type
and delete that.

Although large, there are no significant semantic
changes introduced by this PR.
Owner

rogpeppe commented Mar 7, 2017

$$merge$$

Contributor

jujubot commented Mar 7, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit c67da0e into juju:develop Mar 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment