Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
state: fix flaky tests #7113
Conversation
rogpeppe
changed the title from
state: fix flaky DumpAll test
to
state: fix flaky tests
Mar 16, 2017
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 8e6eef3
into
juju:develop
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rogpeppe commentedMar 16, 2017
•
Edited 1 time
-
rogpeppe
Mar 16, 2017
dumpSuite.TestDumpAll and TestNoModelDocs were
failing because the state workers are now started asynchronously but
this tests was relying on their side-effects (creating
collections) taking place immediately.
Other tests relying on setting the state clock were
also failing the race detector for similar reasons.
Fixes https://bugs.launchpad.net/juju/+bug/1673544, https://bugs.launchpad.net/juju/+bug/1673552 and https://bugs.launchpad.net/juju/+bug/1673554.