Add support for apt-no-proxy option

[wupeka]

Description of change

Add support for apt-no-proxy - disable proxy for apt for selected hosts.

QA steps

1. juju model-config apt-no-proxy=h1,h2,h3
2. deploy unit
3. verify that /etc/apt/apt.config.d/95-juju-proxy-settings contains Apt::::"" "DIRECT"; lines for protocols in http, https, ftp and host in h1, h2 h3

Documentation changes

This option has to be documented in juju/docs

Bug reference

https://bugs.launchpad.net/juju/+bug/1466951

[wupeka]

!!testme!!

[wupeka]

!!test!!

[jameinel]

Did you look into whether plain "http-proxy" ends up mixed in with the apt settings? John =:-> On Mar 17, 2017 19:14, "Witold Krecicki" <notifications@github.com> wrote: !!test!! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7119 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMYfSSYQxkmcjUme2g4JxLP8JQJsxcIks5rmqM5gaJpZM4MgrEH> .

[wupeka]

Currently - yes, it is a fallback if apt-*-proxy is not present and *-proxy is present.
I want to add what's in https://bugs.launchpad.net/juju/+bug/1666353 here too and fix both issues at once, I need this PR to have CI tests run.
I'll ask for review once it's ready.

[jameinel]

!!test!!

[jameinel]

All the changes here look sane to me, but it doesn't seem to actually set Acquire:: sort of settings. Is that all done inside the 'utils' package?

[jameinel]

---

FAIL: config_test.go:1090: ConfigSuite.TestAptProxyConfigMap

config_test.go:1102:
c.Assert(cfg.AptProxySettings(), gc.DeepEquals, proxySettings)
... obtained proxy.Settings = proxy.Settings{Http:"http://httpproxy", Https:"https://httpsproxy", Ftp:"ftp://ftpproxy", NoProxy:"127.0.0.1,localhost,::1"}
... expected proxy.Settings = proxy.Settings{Http:"http://httpproxy", Https:"https://httpsproxy", Ftp:"ftp://ftpproxy", NoProxy:""}

This sort of test suite failure should be something you can iterate on without needing to use the bot. Feel free to ping me if you're confused how to run a subset of the test suite on your own machine.

[jameinel]

I realize you might not know things like "go test -check.v -check.f REGEX" to run a subset of the tests for a particular package.

[wupeka]

!!test!!

[jameinel]

Did you get this to a point for another review? I see that the tests have passed

[wupeka]

Yes, it is ready for review. When this one is merged I'll add PR for https://bugs.launchpad.net/juju/+bug/1666353 as it depends on it.

[jameinel]

One minor comment tweak

The changes look good to me. Have you tried running them on a live environment?

One thing I like to do is set up "apt install apt-cacher-ng" on the machine that hosts the main MAAS server, and then configure both MAAS and Juju environments on that machine to use the proxy. It generally makes "bootstrap" and "deploy" quite a bit faster, if you're doing repeated testing. And it gives you an excuse to test the APT settings and see that they are working as expected.

[jameinel]

typo 'apt-no-proxy'

[wupeka]

$$merge$$

[jujubot]

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju