Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Tweak output of cmr list and find, better find query support #7144
Conversation
| - offers, err := api.GetApplicationOffersDetails(filters, permission.ReadAccess) | ||
| + var filtersToUse params.OfferFilters | ||
| + | ||
| + // If there is only one filter term, and no model is specified, add in |
| -Application Charm Connected Store URL Endpoint Interface Role | ||
| -adiff-db2 db2 23 vendor vendor:fred/model.adiff-db2 log http provider | ||
| - mysql db2 requirer | ||
| +Application Charm Connected Store URL Endpoint Interface Role |
babbageclunk
Mar 23, 2017
Member
If we're sorting by source then why not put in the first column? Also, I found "Store" a confusing heading - maybe just call it Controller? I guess it's a bit long. Is controller the only thing that will go in that column?
wallyworld
Mar 23, 2017
Owner
Store is a general term. JAAS for example isn't a controller as such. Let's stick with controller for now and it can be bike shedded.
Reason for not having store in first column is that for the foreseeable future, there will only be one store, and application name is more important. We can adjust the tabular output if needed later.
babbageclunk
Mar 23, 2017
Member
Yeah, that makes sense - I had a feeling that things like JAAS would make Controller not quite right. Adjusting the order later when there are more values for stores makes sense too.
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$mrge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
wallyworld commentedMar 23, 2017
Description of change
The output of the cmr list and find commands is tweaked for readability.
Also, the find endpoints api is fixed so that it requires the model owner to be specified, as distinct from the user making the query. It also supports queries across all models on a controller, so long as only one filter term is specified.
QA steps
bootstrap
create offers
run show-endpoints, find-endpoints, list-offers