/juju

Add CLI and facade methods for offer ACLs #7158

Merged
merged 2 commits into from Mar 28, 2017

Conversation

Reviewers

@babbageclunk babbageclunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@wallyworld @babbageclunk @jujubot
@wallyworld
Owner

wallyworld commented Mar 26, 2017

Description of change

The grant/revoke CLI is extended to be able to act on application offers.
The applicationoffers facade gets new methods to accept requests to modify offer ACLs.
The new ACLs for offers are read, consume, admin.
This PR uses mocks for the state side of things - a followup PR will fill that in as well as use the ACLs to gate operations on offers.
The work borrows heavily from what was done for model ACLs.

QA steps

Basic smoke testing - no functional user changes till the next PR.

@wallyworld wallyworld referenced this pull request Mar 27, 2017

Merged

Offer acl backend #7160

@babbageclunk

babbageclunk approved these changes Mar 28, 2017
View changes

Looks good, thanks!

apiserver/common/crossmodelcommon/state.go
@@ -53,6 +61,11 @@ type stateShim struct {
*state.State
}
+// TODO(wallyworld)
@babbageclunk

babbageclunk Mar 28, 2017

Member

This is coming in the next PR, right?

@jujubot jujubot merged commit f6fdf9c into juju:develop Mar 28, 2017

jujubot added a commit that referenced this pull request Mar 28, 2017

@jujubot
Merge pull request #7160 from wallyworld/offer-acl-backend 
Offer acl backend

## Description of change

Builds on #7158
Please only review commit a863f59
(the third commit "Add state functionality to support offer acls")

Adds state functionality to support ACLs on application offers. The CLI and facade work was done in the previous PR referenced above.
When a new offer is created, the offer creator/owner is given admin access.
Also, "everyone@external" is given read access. Thus offers are visible by default to anyone who has read access to the model.

Next PR will gate access to offers according to the ACLs.

## QA steps

Run new feature tests.
Run grant and revoke CLI after creating an offer.
bf68537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment