Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify subnet watcher used by firewaller worker #7174

Merged
merged 1 commit into from Mar 30, 2017
Merged

Modify subnet watcher used by firewaller worker #7174

merged 1 commit into from Mar 30, 2017

Conversation

wallyworld
Copy link
Member

Description of change

The remote firewaller WatchSubnets() API is renamed to WatchIngressAddressesForRelation() and now uses a notify watcher and not a strings watcher.

Followup work is need to fill out the new backend implementation.

QA steps

Smoke test a CMR deployment.

@wallyworld wallyworld changed the title Modify subnet watcher ^Ctcher used by firewaller worker Modify subnet watcher used by firewaller worker Mar 30, 2017
babbageclunk
babbageclunk approved these changes Mar 30, 2017
View reviewed changes
Copy link
Contributor

@babbageclunk babbageclunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I'll rip out the watcher wrapper once I redo the watching.

@wallyworld
Copy link
Member Author

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Mar 30, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Mar 30, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10576

@wallyworld
Copy link
Member Author

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Mar 30, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 9a8535b into juju:develop Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babbageclunk babbageclunk babbageclunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@wallyworld @jujubot @babbageclunk