/juju

Modify subnet watcher used by firewaller worker #7174

Merged
merged 1 commit into from Mar 30, 2017

Conversation

Reviewers

@babbageclunk babbageclunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@wallyworld @jujubot @babbageclunk
@wallyworld
Owner

wallyworld commented Mar 30, 2017

Description of change

The remote firewaller WatchSubnets() API is renamed to WatchIngressAddressesForRelation() and now uses a notify watcher and not a strings watcher.

Followup work is need to fill out the new backend implementation.

QA steps

Smoke test a CMR deployment.

@wallyworld wallyworld changed the title from Modify subnet watcher ^Ctcher used by firewaller worker to Modify subnet watcher used by firewaller worker Mar 30, 2017

@babbageclunk

babbageclunk approved these changes Mar 30, 2017
View changes

Looks good - I'll rip out the watcher wrapper once I redo the watching.

@wallyworld
Owner

wallyworld commented Mar 30, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Mar 30, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Mar 30, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10576
@wallyworld
Owner

wallyworld commented Mar 30, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Mar 30, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 9a8535b into juju:develop Mar 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment