Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
BUG 1677425: Gracefully handle NetworkInterfaces() returning NotSuppo… #7175
Conversation
| - if err != nil { | ||
| + if errors.IsNotSupported(err) { | ||
| + // It's possible to have a networking environ, but not support | ||
| + // NetworkInterfaces(). In leiu of adding SupportsNetworkInterfaces(): |
|
$$merge$$ |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$sigh$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit cf4dd62
into
juju:develop
Mar 30, 2017
hmlanigan
deleted the
hmlanigan:bug-1677425
branch
Mar 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
hmlanigan commentedMar 30, 2017
…rted
Please provide the following details to expedite Pull Request review:
Description of change
Fix for Bug 1675799, gracefully handle NetworkInterface() returning NotSupported
when a Network Environ is available.
QA steps
Documentation changes
no
Bug reference
https://bugs.launchpad.net/juju/+bug/1677425