Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gzip compression in the Juju GUI handlers. #7179

Merged
merged 1 commit into from Mar 31, 2017

Conversation

frankban
Copy link
Member

Enable gzip compression on embedded GUI handlers, so that clients don't have to download the GUI uncompressed files.

QA: bootstrap and run juju gui --browser. Log into the GUI and check that everything works as usual, and that gzip compression is enabled.

@bac
Copy link

bac commented Mar 30, 2017

Please fix the typo in the PR title as it goes into the commit message. s/enamble/enable/

@frankban frankban changed the title Enamble gzip compression in the Juju GUI handlers. Enable gzip compression in the Juju GUI handlers. Mar 30, 2017
Copy link
Contributor

@mhilton mhilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bac
Copy link

bac commented Mar 30, 2017

QA-OK

Everything behaves well and is shown to be gzipped. Thanks.

@frankban
Copy link
Member Author

Thanks for the reviews!
$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Mar 31, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit d7ff1fe into juju:develop Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants