/juju

Enable gzip compression in the Juju GUI handlers. #7179

Merged
merged 1 commit into from Mar 31, 2017

Conversation

Reviewers

@bac bac

@axw axw

@mhilton mhilton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@frankban @bac @jujubot @axw @mhilton
@frankban
Member

frankban commented Mar 30, 2017

Enable gzip compression on embedded GUI handlers, so that clients don't have to download the GUI uncompressed files.

QA: bootstrap and run juju gui --browser. Log into the GUI and check that everything works as usual, and that gzip compression is enabled.
@bac

bac commented Mar 30, 2017

Please fix the typo in the PR title as it goes into the commit message. s/enamble/enable/

@frankban frankban changed the title from Enamble gzip compression in the Juju GUI handlers. to Enable gzip compression in the Juju GUI handlers. Mar 30, 2017

@bac

bac approved these changes Mar 30, 2017
View changes

@mhilton

mhilton approved these changes Mar 30, 2017
View changes

LGTM

@bac

bac commented Mar 30, 2017 •
Edited 1 time

QA-OK

Everything behaves well and is shown to be gzipped. Thanks.
@axw

axw approved these changes Mar 31, 2017
View changes

@frankban
Member

frankban commented Mar 31, 2017

Thanks for the reviews!
$$merge$$
@jujubot
Contributor

jujubot commented Mar 31, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit d7ff1fe into juju:develop Mar 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment