/juju

provider/vsphere: implement Instance.Status #7197

Merged
merged 1 commit into from Apr 10, 2017

Conversation

Reviewers

@anastasiamac anastasiamac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@axw @jujubot @anastasiamac
@axw
Member

axw commented Apr 4, 2017

Description of change

Implement Instance.Status properly, in terms of the
VM power state. The status is "running" if the machine
is powered on. This change is required for model
migration to work with vsphere.

QA steps

  1. juju bootstrap vsphere
  2. juju status -m controller --format=yaml
    the machine status should be "running", with a message of "poweredOn"

Documentation changes

No.

Bug reference

https://bugs.launchpad.net/juju/+bug/1679563
@axw
provider/vsphere: implement Instance.Status 
Implement Instance.Status properly, in terms of the
VM power state. The status is "running" if the machine
is powered on. This change is required for model
migration to work with vsphere.
This commit was signed with a verified signature.
@axw axw Andrew Wilkins
GPG key ID: 55314F7628952B05 Learn about signing commits
2ffe906
@anastasiamac

anastasiamac approved these changes Apr 10, 2017
View changes

This is awesome! Thank you :D

provider/vsphere/environ_availzones_test.go
@@ -45,7 +45,7 @@ func (s *environAvailzonesSuite) TestInstanceAvailabilityZoneNames(c *gc.C) {
c.Assert(err, jc.ErrorIsNil)
vmName, err := namespace.Hostname("1")
c.Assert(err, jc.ErrorIsNil)
- s.FakeInstancesWithResourcePool(client, vsphere.InstRp{Inst: vmName, Rp: "rp1"})
@anastasiamac

anastasiamac Apr 10, 2017

Member

Thank you for this rename \o/

@axw
Member

axw commented Apr 10, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Apr 10, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 7b6c96a into juju:develop Apr 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment