Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
cmd/cmdtesting: rename from cmd/testing #7213
Conversation
|
!!build!! |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 83112fe
into
juju:develop
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rogpeppe commentedApr 7, 2017
•
Edited 1 time
-
rogpeppe
Apr 7, 2017
Also move the command testing helpers from
the top level testing package.
This is because we don't want to add a cmd/modelcmd
dependency to juju/testing, but having cmd testing
helpers in one place seems like a Good Thing.
Left for the future: use the almost-identical github.com/juju/cmd/cmdtesting
throughout.
We rename the RunCommand that was currently in cmd/testing
to RunCommandWithDummyProvider to avoid the name clash.
We also needed to make the resource/cmd tests external because of
a dubious-looking import cycle caused by this import cycle:
The apiserver package should really not import any cmd packages,
but that can be fixed some other day.
QA: no regressions.