/juju

Fix modelcmd refactoring romulus #7214

Merged
merged 1 commit into from Apr 7, 2017

Conversation

Reviewers

@sinzui sinzui

@ExternalReality ExternalReality

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@cmars @jujubot @sinzui @ExternalReality
@cmars
Owner

cmars commented Apr 7, 2017

Description of change

Why is this change needed?

Fixes https://bugs.launchpad.net/juju/+bug/1680883

QA steps

How do we verify that the change works?

juju sla --help won't panic. It will also have modelcmd.ModelCommandBase flags registered (-m|--model).

Documentation changes

Does it affect current user workflow? CLI? API?

No.

Bug reference

Does this change fix a bug? Please add a link to it.

https://bugs.launchpad.net/juju/+bug/1680883

@cmars cmars changed the base branch from staging to develop Apr 7, 2017

@cmars
Owner

cmars commented Apr 7, 2017

!!build!!
@sinzui

sinzui approved these changes Apr 7, 2017
View changes

Thank you. LGTM.

@cmars
Owner

cmars commented Apr 7, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Apr 7, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit d3fd535 into juju:develop Apr 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment