Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
juju-{os}-machines metric #7228
Conversation
cmars
changed the base branch from
staging
to
develop
Apr 12, 2017
|
!!build!! |
wallyworld
approved these changes
Apr 12, 2017
Can we address the "unknown" OS type count before landing?
| for _, machine := range allMachines { | ||
| ct := machine.ContainerType() | ||
| if ct == instance.NONE || ct == "" { | ||
| machineCount++ | ||
| + if osType, err := series.GetOSFromSeries(machine.Series()); err != nil { | ||
| + logger.Warningf("failed to resolve OS name for series %q: %v", machine.Series(), err) |
wallyworld
Apr 12, 2017
Owner
IMO we should count these as "unknown OS".
We can still show the tally to the user. Otherwise the numbers won't add up.
| + if osType, err := series.GetOSFromSeries(machine.Series()); err != nil { | ||
| + logger.Warningf("failed to resolve OS name for series %q: %v", machine.Series(), err) | ||
| + } else { | ||
| + n := osMachineCount[osType] |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit b9d19ca
into
juju:develop
Apr 12, 2017
1 check failed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cmars commentedApr 12, 2017
Description of change
To count the number of non-container machines per operating system in a model.
QA steps
Bootstrap a controller, add a model, add some machines to that model.
juju metrics --allshould show metrics, such that:juju-machinesis the total count of non-container machines in the model.juju-ubuntu-machinesis the count of non-container Ubuntu machines in the model.juju-windows-machinesis the count of non-container Windows machines in the model.juju-centos-machinesis the count of non-container CentOS machines in the model.Documentation changes
No.
Bug reference
N/A