Add --no-switch to juju bootstrap and add-model

[mjs]

Description of change

When performing operations in a script or in parallel the automatic switching to new controllers and models can lead to surprises and unwanted actions. juju bootstrap and juju add-model now take a -S / --no-switch flag to suppress this behaviour.

QA steps

# bootstrap with --no-switch works but doesn't select new controller
$ juju bootstrap dev devx --no-switch
Creating Juju controller "devx" on dev
...
Initial model "default" added.
$ juju switch
dev:admin/k3

# conventional bootstrap works as before
$ juju bootstrap dev devy            
Creating Juju controller "devy" on dev
...
Initial model "default" added.
$ juju switch
devy:admin/default

# add-model with --no-switch works but doesn't select the new model
$ juju add-model --no-switch frog
Using credential 'localhost' cached in controller
Added 'frog' model with credential 'localhost' for user 'admin'
$ juju switch
devy:admin/default

# conventional add-model works as before
$ juju add-model dog
Using credential 'localhost' cached in controller
Added 'dog' model with credential 'localhost' for user 'admin'
$ juju switch
devy:admin/dog

Documentation changes

Perhaps worth mentioning but this is fairly minor.

Bug reference

https://bugs.launchpad.net/juju/+bug/1618234

[jameinel]

I'm not sure that we want -S as a short variable, it doesn't feel like this would be used enough.

Also, IMO, if you are going to have "no-foo" then you should also have "foo" so that any sort of change-to-the-default can always be done compatibly in the future.

[mjs]

As per IRC, I'll canvass some opinions on this. If we're going to do --switch (default to true) then I'd prefer to not have a --no-switch. It seems weird to me to have to competing flags.

Then people would do --switch=false if they don't want switching.

[cmars]

I will use the heck out of this feature, because I automate Juju with scripts. I like -S quite a bit.

[jameinel]

I didn't think gnuflag supported --flag=false, I thought that was only supported by default go Flag package. I would say --no-switch=false is a lot worse than --switch/--switch=true/false Double negatives are very hard to understand. If we do support =false, then I'm in favor of --switch=false rather than --no-switch=false to mean switch. John =:->

…

On Thu, Apr 13, 2017 at 3:37 PM, Menno Smits ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In cmd/juju/commands/bootstrap.go <#7237 (comment)>: > f.BoolVar(&c.showClouds, "clouds", false, "Print the available clouds which can be used to bootstrap a Juju environment") f.StringVar(&c.showRegionsForCloud, "regions", "", "Print the available regions for the specified cloud") + f.BoolVar(&c.noGUI, "no-gui", false, "Do not install the Juju GUI in the controller when bootstrapping") + f.BoolVar(&c.noSwitch, "S", false, "Do not switch to the newly created controller") As per IRC, I'll canvass some opinions on this. If we're going to do --switch (default to true) then I'd prefer to not have a --no-switch. It seems weird to me to have to competing flags. Then people would do --switch=false if they don't want switching. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#7237 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMYfbFiYjQCnAw5uYLhgamKtKGNPpjXks5rvgj6gaJpZM4M8kdN> .

[cmars]

@jameinel I disagree. I think a capitalized short -S flag, and a --no-switch long flag fit the existing idiom in the Juju CLI really well, for example:

-B, --no-browser-login  (= false)
    Do not use web browser for authentication

I'd rather be consistent than anything else.

[mjs]

Given that various --no-<something> switches already exist on juju bootstrap and elsewhere, I'm going to leave this as-is. It's unfortunate and unconventional that gnuflag takes an value for boolean command line flags.

[mjs]

$$merge$$

[jujubot]

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

[jujubot]

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10712

[nskaggs]

!!build!!

[nskaggs]

!!build!!

[mjs]

Looks like the changes are now incompatible with the current develop branch. I'll fix on Monday.

[mjs]

$$merge$$

[jujubot]

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

[jujubot]

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10729

[mjs]

$$vsphere-flakiness$$

[jujubot]

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

[jujubot]

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10732

[mjs]

$$merge$$

[jujubot]

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

[jujubot]

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10738

[mjs]

$$mongodb-on-windows$$

[jujubot]

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju