Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Update Makefile to utilize go-1.8, update old dependencies #7273
Conversation
|
Note, I'll be running test builds in here to verify this with CI. |
|
!!build!! |
|
!!build!! |
|
!!build!! |
| @@ -98,14 +96,12 @@ rebuild-dependencies.tsv: godeps | ||
| # Install packages required to develop Juju and run tests. The stable | ||
| # PPA includes the required mongodb-server binaries. | ||
| install-dependencies: | ||
| -ifeq ($(shell lsb_release -cs|sed -r 's/precise|wily/old/'),old) | ||
| - @echo Adding juju PPAs for golang and mongodb-server | ||
| + @echo Adding PPAs for golang and juju |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Generating tarball failed |
|
!!build!! |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Generating tarball failed |
|
Build failed: Tests failed |
|
Build failed: Tests failed |
nskaggs commentedApr 24, 2017
Description of change
This change updates the Makefile to depend on go-1.8 only for non gcc-go.
Why is this change needed? This change allows us to build with go-1.8, which will be required for new changes going forward.
QA steps
The github-check-merge job is currently experimenting with building with go-1.8 to minimize impact. Once that job blesses this PR, we should be good to merge.
In addition, manual verification of running make install-dependencies.
This helps land https://bugs.launchpad.net/juju/+bug/1683099