/juju

cmd/modelcmd: rename CommandBase to Command #7283

Merged
merged 1 commit into from Apr 26, 2017

Conversation

Reviewers

@jameinel jameinel

@mhilton mhilton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rogpeppe @jujubot @jameinel @mhilton
@rogpeppe
Owner

rogpeppe commented Apr 26, 2017

The "CommandBase" name is inconsistent with all the other *Base
names - it's an interface but all the others (ControllerCommandBase,
ModelCommandBase and cmd.CommandBase) are static embeddable structs.
This is confusing, so rename it to Command, allowing us to rename the
awkwardly-differentiated JujuCommandBase to CommandBase.

This PR was entirely mechanically generated with

gorename -from '"github.com/juju/juju/cmd/modelcmd".CommandBase' -to Command
gorename -from '"github.com/juju/juju/cmd/modelcmd".JujuCommandBase' -to CommandBase

with the exception of some of the comment adjustments.

QA No regressions
@rogpeppe
cmd/modelcmd: rename CommandBase to Command 
The "CommandBase" name is inconsistent with all the other *Base
names - it's an interface but all the others (ControllerCommandBase,
ModelCommandBase and cmd.CommandBase) are static embeddable structs.
This is confusing, so rename it to Command, allowing us to rename the
awkwardly-differentiated JujuCommandBase to CommandBase.

This PR was entirely mechanically generated with

	gorename -from '"github.com/juju/juju/cmd/modelcmd".CommandBase' -to Command
	gorename -from '"github.com/juju/juju/cmd/modelcmd".JujuCommandBase' -to CommandBase

with the exception of some of the comment adjustments.
31f6ae1
@mhilton

mhilton approved these changes Apr 26, 2017
View changes

LGTM

@jameinel

jameinel approved these changes Apr 26, 2017
View changes

LGTM

@rogpeppe
Owner

rogpeppe commented Apr 26, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Apr 26, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 0fb0864 into juju:develop Apr 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment