Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
cmd/juju/commands: make migrateCommand use ModelCommandBase #7302
Conversation
rogpeppe
changed the title from
cmd/juju/commands: make mgrateCommand use ModelCommandBase
to
cmd/juju/commands: make migrateCommand use ModelCommandBase
May 3, 2017
|
(looks like an intermittent CI failure) !!build!! |
mjs
approved these changes
May 3, 2017
Thanks for the tidy up. I'm +1 for this as long as:
- you're sure the command line API for "juju migrate" hasn't changed (sees that way)
- you've confirmed that the "juju migrate" command still works.
|
Confirmed both points above - I ran a successful migration and checked the command line API. |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit b1f4b75
into
juju:develop
May 4, 2017
1 check failed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rogpeppe commentedMay 3, 2017
This means that it can re-use the standard model-finding
logic rather than duplicating it slightly differently,
so that the user will have consistent behaviour
across all commands (less code too)
QA check that the migrate command still works.