/juju

cmd/modelcmd: use FakeJujuXDGDataHomeSuite #7321

Merged
merged 1 commit into from May 10, 2017

Conversation

Reviewers

@babbageclunk babbageclunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@axw @jujubot @babbageclunk
@axw
Member

axw commented May 10, 2017

Description of change

Use FakeJujuXDGDataHomeSuite to initialise the
"XDG" home directory for tests, isolating them
from one another. We were setting a fake home
directory which isn't sufficient for Windows.

QA steps

Run the tests.

Documentation changes

None.

Bug reference

None.
@axw
cmd/modelcmd: use FakeJujuXDGDataHomeSuite 
Use FakeJujuXDGDataHomeSuite to initialise the
"XDG" home directory for tests, isolating them
from one another. We were setting a fake home
directory which isn't sufficient for Windows.
This commit was signed with a verified signature.
@axw axw Andrew Wilkins
GPG key ID: 55314F7628952B05 Learn about signing commits
b42f101
@babbageclunk

babbageclunk approved these changes May 10, 2017
View changes

Looks great!

@axw
Member

axw commented May 10, 2017

$$merge$$
@jujubot
Contributor

jujubot commented May 10, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit e634386 into juju:develop May 10, 2017
1 check passed

1 check passed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment