apiserver: return PublicHostName in login results #7323

Merged
merged 1 commit into from May 10, 2017

Conversation

Projects
None yet
5 participants
Owner

rogpeppe commented May 10, 2017

This will enable a client to know if a server supports connections
with officially signed certificates and store that fact in the controllers.yaml file.

Also move a few doc comments from the private api.state methods
onto the public api.Connection interface.

LGTM

axw approved these changes May 10, 2017

api/apiclient_test.go
+ // so we can check that the PublicDNSName in the result goes
+ // all the way through the layers.
+ listener, err := net.Listen("tcp", "localhost:0")
+ c.Assert(err, gc.IsNil)
@axw

axw May 10, 2017

Member

defer listener.Close() ?

@rogpeppe

rogpeppe May 10, 2017

Owner

NewServer closes the listener when it stops - I've added a comment.

apiserver: return PublicHostName in login results
This will enable a client to know if a server supports connections
with officially signed certificates and store that fact in the controllers.yaml file.

Also move a few doc comments from the private api.state methods
onto the public api.Connection interface.
Owner

rogpeppe commented May 10, 2017

$$merge$$

Contributor

jujubot commented May 10, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented May 10, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10859

Owner

rogpeppe commented May 10, 2017

$$merge$$

Contributor

jujubot commented May 10, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 9896da8 into juju:develop May 10, 2017

1 check failed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment