Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
juju: remember public hostname in controllers.yaml #7324
Conversation
|
!!build!! |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 7a80bd8
into
juju:develop
May 11, 2017
1 check passed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rogpeppe commentedMay 10, 2017
This means that however we log in (for example
via juju register), the public hostname is remembered in controllers.yaml.
Also, we use the public hostname information when connecting
to the controller.
We also tidy up some of the code called by juju.NewAPIConnection
to try to make the logic more understandable, renaming
and unexporting the somewhat baroque PrepareEndpointsForCaching
function.
QA: when registering a public controller, check that the public-dns-name
entry is set in controllers.yaml. Also, check that normal juju commands
still work.