Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
all: remove ExternalControl from migration #7328
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Generating tarball failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 528ddf5
into
juju:develop
May 11, 2017
1 check passed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rogpeppe commentedMay 10, 2017
Following from a remark from Menno, both ExternalControl
and SkipInitialPrechecks were only there if full migrations
were not implemented in time, but they're implemented now
so we can remove them.
This prepares for adding CACert-fetching logic to the
initial pre-check in the apiserver InitiateMigration logic - that
didn't make sense if the pre-check was optional.
QA no migration regressions.