Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
api: fall back to using public cert on cert error #7338
Conversation
|
!!build!! |
| urlStr string | ||
| tlsConfig *tls.Config | ||
| } | ||
| +// Close implements io.Close by closing the websocket |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
$$merge$$ |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit b2b4b05
into
juju:develop
May 18, 2017
1 check failed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rogpeppe commentedMay 12, 2017
•
Edited 1 time
-
rogpeppe
May 17, 2017
If we get a certificate error trying to connect to a controller,
then it's possible that we're using the private CA but
the address we're connecting to is a proxy that doesn't
have a private CA certificate. In this case, try
again with the public CA.
To test this properly, some refactoring was required. A brief overview:
an internal dialOpts type rather than having unexported fields in the otherwise-public
DialOpts type.
QA do a model migration to a controller with a frontend proxy.