Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
cmd/juju/application: Document placement for multiple units #7343
Conversation
wallyworld
approved these changes
May 16, 2017
We should mention what happens when n > number of placement directives. ie new machines are used after all the directives have been consumed
|
@wallyworld: good idea. done. |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
babbageclunk
approved these changes
May 16, 2017
Minor bikeshedding, looks like a good change though.
| +or load-balancing. See the documentation for specfic charms to check | ||
| +how scale-out is supported. | ||
| + | ||
| +The add-unit is applied to applications that have already been |
mjs
May 16, 2017
Contributor
That was typo. I've fixed this and made some more extensive improvements.
| +how scale-out is supported. | ||
| + | ||
| +The add-unit is applied to applications that have already been | ||
| +deployed. By default, applications are deployed to newly provisioned |
| juju add-unit wordpress -n 5 | ||
| -Add one unit of mysql to the existing machine 23: | ||
| - | ||
| +Add a unit of mysql to an existing machine: |
| juju add-unit mysql --to 23 | ||
| -Create a new LXD container on machine 7 and add one unit of mysql: | ||
| +Add two units of mysql to two preexisting machines: |
babbageclunk
May 16, 2017
Member
So here should be "to preexisting machines 3 and 4".
If you want to be really cool you could use a diaeresis on the second e! ;)
https://www.reddit.com/r/grammar/comments/2h9h08/article_in_the_new_yorker_uses_the_word/
mjs
May 16, 2017
Contributor
That's interesting and weird. With my rewording the word "preëxisting" no longer exists in the text :)
| +Add two units of mysql to two preexisting machines: | ||
| + juju add-unit mysql -n 2 --to 3,4 | ||
| + | ||
| +Add three units of mysql to one preexisting machine: |
babbageclunk
May 16, 2017
Member
I guess by here it's probably fine not to specify which machine it is.
| +Add a unit of mariadb to LXD container number 3 on machine 24: |
| juju deploy haproxy -n 2 --constraints spaces=dmz,^cms,^database | ||
| - (deploy 2 units to machines that are part of the 'dmz' space but not of the | ||
| - 'cmd' or the 'database' spaces) | ||
| + (deploy 2 units to machines that are part of the 'dmz' space but |
babbageclunk
May 16, 2017
Member
"Part of" seems awkward here - what about just "in the 'dmz' space but not in the 'cmd' or 'database' spaces"?
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Generating tarball failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$mongodb-died-windows$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
mjs commentedMay 16, 2017
Description of change
It wasn't clear how to specify placement when multiple units were being created with add-unit and deploy. The syntax for
--towith multiple targets is now documented.Some other general clean ups of the help for these commands was also made.
QA steps
juju add-unit -handjuju deploy -hDocumentation changes
N.A.
Bug reference
https://bugs.launchpad.net/juju/+bug/1687663