/juju

worker/provisioner: Increase start instance retry limit #7351

Merged
merged 1 commit into from May 16, 2017

Conversation

Reviewers

@wallyworld wallyworld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@babbageclunk @jujubot @wallyworld
@babbageclunk
Member

babbageclunk commented May 16, 2017

Description of change

QA are seeing a MAAS deployment timeout occasionally, it looks like it's
caused by the retry limit in the provisioner - in some cases MAAS is
busy enough that 3 failures might happen while trying to start an
instance.

Bump up the retry limit to 10 as a simple fix for the immediate problem

  • the longer term fix is to use better retry/backoff logic (will do this as a
    separate change).

QA steps

Deploying still works on MAAS.
It's hard to reproduce this problem on my own MAAS.

Bug reference

Fixes https://bugs.launchpad.net/juju/+bug/1688028
@babbageclunk
Increase provisioner start instance retry count 
QA are seeing a MAAS deployment timeout occasionally, it looks like it's
caused by the retry limit in the provisioner - in some cases MAAS is
busy enough that 3 failures might happen while trying to start an
instance.

Bump up the retry limit to 10 as a simple fix for the immediate problem
- the longer term fix is to use better backoff logic (will do this as a
separate change).

Fixes https://bugs.launchpad.net/juju/+bug/1688028
13956a8
@babbageclunk
Member

babbageclunk commented May 16, 2017

$$merge$$
@jujubot
Contributor

jujubot commented May 16, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 0be1f59 into juju:develop May 16, 2017
1 check passed

1 check passed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details

@babbageclunk babbageclunk deleted the babbageclunk:maas-bug branch May 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment