Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
state: prevent `using unknown collection "remoteApplications"` error #7352
Conversation
babbageclunk
added some commits
May 17, 2017
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
Gah, test run killed because we exceeded our instance quota. $$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit b8999ab
into
juju:develop
May 17, 2017
1 check passed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
babbageclunk
deleted the
babbageclunk:unknown-collection
branch
May 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
babbageclunk commentedMay 17, 2017
Description of change
The
state/applicationByNamefunction would always try to get a remote application, and if that wasn't found would get an application instead. Change this to try returning a local application first (this will generally be the right thing), then if that's not found and the cross model flag is set try getting a remote application instead.If neither are found, we still return the error
application "needle" not found. This is less confusing for the user, since it's probably what they were intending, and remote applications are also (conceptually) applications so it's not wrong in that case either.QA steps
unknown collection "remoteApplications"