Disable debinterfaces tests on Windows #7353

Merged
merged 1 commit into from May 18, 2017

Conversation

Projects
None yet
4 participants
Member

wupeka commented May 17, 2017

Please provide the following details to expedite Pull Request review:

Disable debinterfaces activation tests on Windows, those are Linux specific.
Fix debinterfaces parsing tests on Windows.

Description of change

Tests were failing on Windows

QA steps

Tests for debinterfaces should pass on Windows.

Member

wupeka commented May 17, 2017

!!Test!!

we have github.com/juju/juju/testing.SkipIfWindowsBug()

I'm not sure if we would ever intend for BridgeSuite to pass on Windows. Parser feels more like something that we should make pass, rather than skip. (we shouldn't be depending on shelling out to a command to parse the file, right?)

So BridgeSuite feels like something we might not ever intend to fix, so creating a bug doesn't feel appropriate. But for ParserSuite, if we aren't fixing it now, then we should have a bug to come back to this.
There's an argument whether it is worth the effort, but IMO, not running go code on Windows is usually a sign of not-very-good-code and is likely to bite us again somewhere, which is generally why I feel Skip() should be reserved for things that really won't run everywhere.

Member

wupeka commented May 18, 2017

I don't think SkipIfWindowsBug is appropriate here because it's not a bug, we are skipping some tests this way.
parser_tests are fixed - those should work on Windows without problem now (although I don't have environment to test it)

Member

babbageclunk commented May 18, 2017

$$merge$$

Member

babbageclunk commented May 18, 2017

Merging because @wupeka asked me to on IRC.

Contributor

jujubot commented May 18, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 2370424 into juju:develop May 18, 2017

1 check passed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details

jujubot added a commit that referenced this pull request May 23, 2017

Merge pull request #7377 from wupeka/windows-unit-test-fix
Fix E/N/I unit test on Windows

## Description of change
Follow up from #7353, one test needed fixing

## QA steps
Check that run-unit-tests-win2012-amd64 job passes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment