Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Disable debinterfaces tests on Windows #7353
Conversation
|
!!Test!! |
jameinel
approved these changes
May 17, 2017
we have github.com/juju/juju/testing.SkipIfWindowsBug()
I'm not sure if we would ever intend for BridgeSuite to pass on Windows. Parser feels more like something that we should make pass, rather than skip. (we shouldn't be depending on shelling out to a command to parse the file, right?)
So BridgeSuite feels like something we might not ever intend to fix, so creating a bug doesn't feel appropriate. But for ParserSuite, if we aren't fixing it now, then we should have a bug to come back to this.
There's an argument whether it is worth the effort, but IMO, not running go code on Windows is usually a sign of not-very-good-code and is likely to bite us again somewhere, which is generally why I feel Skip() should be reserved for things that really won't run everywhere.
|
I don't think SkipIfWindowsBug is appropriate here because it's not a bug, we are skipping some tests this way. |
|
$$merge$$ |
|
Merging because @wupeka asked me to on IRC. |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
wupeka commentedMay 17, 2017
•
Edited 1 time
-
wupeka
May 18, 2017
Please provide the following details to expedite Pull Request review:
Disable debinterfaces activation tests on Windows, those are Linux specific.
Fix debinterfaces parsing tests on Windows.
Description of change
Tests were failing on Windows
QA steps
Tests for debinterfaces should pass on Windows.