Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add info to list-clouds output to list maas and other such providers #7365
Conversation
| -func queryCloudType(pollster *interact.Pollster) (string, error) { | ||
| +// cloudProviders returns the names of providers supported by add-cloud, | ||
| +// and also the names of those which are not supported. | ||
| +func cloudProviders() (providers []string, unsupported []string, _ error) { |
axw
May 19, 2017
Member
The function name could explain what it returns a bit better. Maybe "addableCloudProviders" (sounds a bit weird, but explains better...)?
| w.Println("Update the known public clouds with 'update-clouds'.") | ||
| + w.Println("'add-cloud' can add private clouds or private infrastructure built using:") |
wallyworld
added some commits
May 19, 2017
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 82596f7
into
juju:develop
May 20, 2017
1 check failed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wallyworld commentedMay 19, 2017
Description of change
juju clouds output is improved to show private cloud providers like maas
QA steps
$ juju clouds
Cloud Regions Default Type Description
aws 14 us-east-1 ec2 Amazon Web Services
aws-china 1 cn-north-1 ec2 Amazon China
aws-gov 1 us-gov-west-1 ec2 Amazon (USA Government)
Try 'list-regions ' to see available regions.
'show-cloud ' or 'regions --format yaml ' can be used to see region endpoints.
Update the known public clouds with 'update-clouds'.
'add-cloud' can add private clouds or private infrastructure built using:
^^^^^ new