Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
provider/common: fix TestSuccess for Windows #7371
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit c3b5534
into
juju:develop
May 22, 2017
1 check failed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
axw commentedMay 22, 2017
Description of change
Fix the TestSuccess test for Windows. We need
to have both "scp" and "ssh" in the path for
the OpenSSH client code to succeed. Also,
unquote the user known hosts file path, and
return errors properly.
QA steps
Run TestSuccess on Windows and Linux.
Documentation changes
None.
Bug reference
None.