Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Patch file to fix races in upstream gosigma library #7375
Conversation
babbageclunk
approved these changes
May 23, 2017
This looks like a good patch (although I don't really know about the gosigma library).
| -For more details, see `lp:juju-release-tools/apply_patches.py` or ask | ||
| -babbageclunk or mgz in IRC. | ||
| +For more details, see `https://github.com/juju/juju/releasetests/apply_patches.py` | ||
| +or ask babbageclunk in IRC. |
babbageclunk
May 23, 2017
Member
Good call, Martin probably isn't super interested in hearing about this. I think balloons is an about-this-knower as well, may as well put him in here.
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$Merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
wallyworld commentedMay 23, 2017
Description of change
Various races attributed to the github.com/altoros/gosigma repo appear in Juju's CI test runs. The fixes are proposed upstream at Altoros/gosigma#1
Until that code lands, this PR delivers a patch that is applied to Juju to fix the issues.
QA steps
go test -race on altoros/gosigma repo