/juju

Don't attempt to use max-txn-log-size on upgrades #7410

Merged
merged 1 commit into from May 29, 2017

Conversation

Reviewers

@babbageclunk babbageclunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@wallyworld @jujubot @babbageclunk
@wallyworld
Owner

wallyworld commented May 28, 2017

Description of change

Upgrading Juju paniced because when state was opened for the upgrade, the max-txn-log-size attribute was missing. This value would have been filled in by the upgrade steps, so it's a catch 22 thing. But the thing is, the max-txn-log-size is only useful when bootstrapping, because capped collections cannot be resized yet (https://jira.mongodb.org/browse/SERVER-1864). So now we only use the max-txn-log-size when initialising state on bootstrap, not on subsequent opens.

QA steps

bootstrap older juju
upgrade

Bug reference

https://bugs.launchpad.net/bugs/1694116
@babbageclunk

babbageclunk approved these changes May 28, 2017
View changes

Looks good to me.

@wallyworld
Owner

wallyworld commented May 28, 2017

$$merge$$
@jujubot
Contributor

jujubot commented May 28, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit eb6888c into juju:develop May 29, 2017
1 check failed

1 check failed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment