Return original error when retrying TLS connection with system wide CA set #7414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wupeka
force-pushed
the
websockets-tls-error
branch
from
a6a2ebd
to
47f4731
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
May 30, 2017
Better log message in case of TLS error ## Description of change Follow up from #7414 - lower error message level. ## QA steps Check debug level log messages on TestUpdateCert unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
There is a fallback to system CA set if root CA is set and server cert fails verification. If it fails we should return original error as it's more specific. This is especially important on Windows as with current code a certificate that's expired but is correctly signed by custom CA will fail as unsigned (by system CA) instead of expired.
QA steps
Check TestUpdateCert unit test on Windows.