Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
api: fix intermittent test failure #7428
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 85a59a0
into
juju:develop
Jun 1, 2017
1 check failed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
axw commentedJun 1, 2017
Description of change
TestWithUnresolvableAddrAfterCacheFallback fails intermittently,
becuase the order in which API connection attempts are made by
the parallel.Try is non-deterministic, and the final error is
always reported.
Instead of checking the error message, just record a boolean
that indicates whether or not we attempted to dial the "real"
address.
QA steps
Run the test a bunch of times, with and without -race.
Documentation changes
None.
Bug reference
None.