Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
dependencies.tsv: update gopkg.in/retry.v1 #7429
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 19854a2
into
juju:develop
Jun 1, 2017
1 check passed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
axw commentedJun 1, 2017
Description of change
This brings in the fix in go-retry/retry#1. This should address http://qa.jujucharms.com/releases/5319/job/run-unit-tests-win2012-amd64/attempt/3809.
QA steps
I temporarily changed TestDialAPIMultipleError to pass in a
fakeClock, which will advance the time exactly the amount requested. Since the sleep amount is 0, the time will not advance, and so the retry would previously loop forever. With the updated dependency, it works as expected.The test would previously fail with the system clock because if the time doesn't advance at all (which is more likely with a low resolution system clock), an additional dial attempt would be made.
Documentation changes
None.
Bug reference
None.