Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Reduce log level of SLA API error. #7439
Conversation
wupeka
approved these changes
Jun 1, 2017
LGTM
Sidenote - I'd add an explicit check of ModelConfig API version instead of calling SLA commands and checking if they fail.
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 21411c3
into
juju:develop
Jun 1, 2017
1 check failed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cmars commentedJun 1, 2017
SLA allocation is removed with best effort. Because the SLA API call
will fail on pre-2.2 controllers, debug level is more appropriate for
this error.
Description of change
Before this change, when using a Juju 2.2 client with pre-2.2 controllers, you'll get an unactionable warning about SLAs when destroying a model, because the controller does not support them:
QA steps
You won't see the API error warning when destroying a model on a pre-2.2 controller.
Documentation changes
No
Bug reference
N/A