Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
merge the latest peer-xplod into core #7463
Conversation
wallyworld
merged commit f256ff3
into
juju:develop
Jun 8, 2017
1 check passed
github-check-merge-juju
Ran tests against PR. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jameinel commentedJun 7, 2017
Description of change
Peer-xplod currently uses python2 for all of its hooks. Xenial doesn't have it installed by default, so we need to install it in the 'install' hook.
This also lets us change the charm into a multi-series charm, and fixes 'categories' vs 'tags' which is something that 'charm proof' complains about.
It also changes it so if you
juju set peer-xplod maximum=0the charm hooks never stop firing, which was the original intent.QA steps
You should be able to
juju deploy ./peer-xplod --series xenialand have it work.Documentation changes
No, this is used for internal testing.
Bug reference
No