apiserver/logsink: extract generic handler code #7496

Merged
merged 1 commit into from Jun 14, 2017

Conversation

Projects
None yet
3 participants
Member

axw commented Jun 13, 2017

Description of change

Extract the logsink HTTP/websocket handler into
a separate package, and tidy up the abstractions
a bit. This precedes work underway to rate-limit
and batch database log writes.

!!DO NOT LAND UNTIL 2.2 IS RELEASED!!

QA steps

  1. juju bootstrap
  2. juju debug-log -m controller

Documentation changes

None.

Bug reference

None.

Owner

wallyworld commented Jun 13, 2017

$$merge$$

Contributor

jujubot commented Jun 13, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Jun 13, 2017

Build failed: Generating tarball failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/11131

apiserver/logsink.go
"github.com/juju/juju/state"
+ "github.com/juju/loggo"
+ "github.com/juju/names"
@wallyworld

wallyworld Jun 13, 2017

Owner

this needs to be names.v2

@axw

axw Jun 14, 2017

Member

fixed, thanks

apiserver/logsink: extract generic handler code
Extract the logsink HTTP/websocket handler into
a separate package, and tidy up the abstractions
a bit. This precedes work underway to rate-limit
and batch database log writes.
Member

axw commented Jun 14, 2017

$$merge$$

Contributor

jujubot commented Jun 14, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit a78d770 into juju:2.2 Jun 14, 2017

1 check passed

github-check-merge-juju Ran tests against PR. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment