Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
apiserver: change default buffer size to 1000, make configurable #7505
Conversation
| + if cfg.DBLoggerBufferSize <= 0 || cfg.DBLoggerBufferSize > 1000 { | ||
| + return errors.NotValidf("DBLoggerBufferSize %d <= 0 or > 1000", cfg.DBLoggerBufferSize) | ||
| + } | ||
| + if cfg.DBLoggerFlushInterval <= 0 { |
wallyworld
Jun 15, 2017
Owner
Can we put an upper bound on this. Like we did for conn throttling config. We want to prevent the user from specifying something stupid.
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 97aa24d
into
juju:2.2
Jun 16, 2017
1 check passed
github-check-merge-juju
Ran tests against PR. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
axw commentedJun 15, 2017
Description of change
Change the default logsink buffer size to 1000,
matching the underlying limit of 1000 for bulk
insertions to Mongo. Also make the buffer size
and flush interval configurable via agent.conf.
QA steps
(observe the log records are flushed at 2 second intervals)
(observe the log records are flushed at 1 second intervals)
(observe the log records are flushed without delay)
Documentation changes
None.
Bug reference
None.