Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Expose unit.Charm() #7508
Conversation
anastasiamac
closed this
Jun 16, 2017
|
I was going to LGTM, why cancel it? |
|
axw and I had a talk about out of band - essentially this is potentially race-y. It was decided that it'd b better to keep this confined to state layer only. |
anastasiamac
deleted the
anastasiamac:unit-charm-expose
branch
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
anastasiamac commentedJun 15, 2017
Description of change
Access to the charm of the unit is useful at apiserver layer too, for example for validation of user supplied names such as payloads.
QA steps
Internal change - unit tests pass.
Documentation changes
n/a
Bug reference
n/a