Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
state: Use StatePool instead of ForModel in AllModelWatcher #7512
Conversation
mjs
added some commits
Jun 19, 2017
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
mjs
referenced this pull request
Jun 19, 2017
Closed
state: Use StatePool instead of ForModel in AllModelWatcher #7513
jujubot
merged commit 725099c
into
juju:2.2
Jun 19, 2017
1 check passed
github-check-merge-juju
Ran tests against PR. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
mjs
deleted the
mjs:1698701-AllModelWatcher-ForModel-2.2
branch
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mjs commentedJun 19, 2017
Description of change
ForModel is inefficient. Starting a AllModelWatcher on a controller with many models would have had a significant resource impact.
Also a drive-by fix for an incorrect call in state/logdb.
QA steps
Bootstrapped a new controller and then connected using this client: https://gist.github.com/mjs/d9d016433e4348b4aa990a8f81d65d03
Deployed software in multiple models and ensured that all expected changes were observed.
Documentation changes
N.A.
Bug reference
https://bugs.launchpad.net/juju/+bug/1698701