Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
state: Removed ForModel call in controller address lookup #7516
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
Build failed: Tests failed |
jujubot
merged commit 8a01312
into
juju:develop
Jun 20, 2017
1 check passed
github-check-merge-juju
Ran tests against PR. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
mjs
deleted the
mjs:1698703-controller-addrs-ForModel
branch
Jun 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mjs commentedJun 20, 2017
Description of change
State.controllerAddresses()was unnecessarily using expensive ForModel calls.QA steps
It turns out that this code is only called by tests. Unit tests still pass.
Documentation changes
N.A.
Bug reference
https://bugs.launchpad.net/juju/+bug/1698703