Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
api: check before using pre-resolved address #7529
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit b8cedcc
into
juju:2.2
Jun 21, 2017
1 check passed
github-check-merge-juju
Ran tests against PR. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
axw commentedJun 21, 2017
Description of change
When dialing a websocket, check that the address
we're asked to dial is the same as the one that
we pre-resolved. It will not match when we're
using a proxy.
This is a short-term fix. If we should be doing
any client-side resolution at all, it should be
disabled when a proxy is to be used.
QA steps
go get github.com/elazarl/goproxy, thengo runthe following program:Documentation changes
None.
Bug reference
Fixes https://bugs.launchpad.net/juju/+bug/1698989