Update CLI for debug-log to handle machines, units, and applications #7543

Merged
merged 1 commit into from Jun 22, 2017

Conversation

Projects
None yet
3 participants
Owner

howbazaar commented Jun 22, 2017

Description of change

The --include and --exclude options for debug-log can now take machines, units, or applications.

QA steps

Bootstrap a controller, deploy two different ubuntu units.

juju debug-log -i ubuntu
juju debug-log -i 1
juju debug-log -i ubuntu/1

Documentation changes

The debug-log section should be updated for the entity specification.

Bug reference

https://bugs.launchpad.net/juju/+bug/1576851

Seeing this makes me wonder if 'debug-log' output should be writing the tags vs the names (machine-0: etc),
But this all looks very good and is a very nice usability improvement.

Owner

howbazaar commented Jun 22, 2017

$$merge$$

Contributor

jujubot commented Jun 22, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Jun 22, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/11181

Owner

jameinel commented Jun 22, 2017

Failure was:
server_test.go:589:
assertStateBecomesClosed(c, st)
server_test.go:616:
c.Assert(checkModel, gc.PanicMatches, "Session already closed")
... function func() = (func())(0x1e15430)
... expected string = "Session already closed"
... Function has not panicked

Seems a flaky test that is asserting things are closed when they are 'already closed'. Unrelated to Tim's patch.

$$merge$$

Contributor

jujubot commented Jun 22, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit b587b5d into juju:2.2 Jun 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment