Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Update CLI for debug-log to handle machines, units, and applications #7543
Conversation
jameinel
approved these changes
Jun 22, 2017
Seeing this makes me wonder if 'debug-log' output should be writing the tags vs the names (machine-0: etc),
But this all looks very good and is a very nice usability improvement.
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
Failure was: Seems a flaky test that is asserting things are closed when they are 'already closed'. Unrelated to Tim's patch. $$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
howbazaar commentedJun 22, 2017
Description of change
The --include and --exclude options for debug-log can now take machines, units, or applications.
QA steps
Bootstrap a controller, deploy two different ubuntu units.
juju debug-log -i ubuntu
juju debug-log -i 1
juju debug-log -i ubuntu/1
Documentation changes
The debug-log section should be updated for the entity specification.
Bug reference
https://bugs.launchpad.net/juju/+bug/1576851