/juju

apiserver/...: fix several auth issues #7607

Merged
merged 1 commit into from Jul 10, 2017

Conversation

Reviewers

@wallyworld wallyworld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@axw @jujubot @wallyworld
@axw
Member

axw commented Jul 10, 2017

Description of change

Backport of auth issues found/fixed in
#7606.

  • logfwd was using AuthMachineAgent, and should
    have used AuthController. It has been updated
    to use the latter.
  • payloads had no auth at all; it has been updated
    to use AuthClient.
  • metricsmanager and undertaker: redundant calls
    to AuthMachineAgent, when AuthController would
    do. Simplified.
  • charmrevisionupdater: was allowing non-controller
    agents, now does not.
  • keymanager and highavailability: both were allowing
    controller unnecessarily; dropped.

QA steps

Run tests. Bootstrap.

Documentation changes

None.

Bug reference

None.
@axw
apiserver/...: fix several auth issues 
Backport of auth issues found/fixed in
#7606.

- logfwd was using AuthMachineAgent, and should
  have used AuthController. It has been updated
  to use the latter.
- payloads had no auth at all; it has been updated
  to use AuthClient.
- metricsmanager and undertaker: redundant calls
  to AuthMachineAgent, when AuthController would
  do. Simplified.
- charmrevisionupdater: was allowing non-controller
  agents, now does not.
- keymanager and highavailability: both were allowing
  controller unnecessarily; dropped.
This commit was signed with a verified signature.
@axw axw Andrew Wilkins
GPG key ID: 55314F7628952B05 Learn about signing commits
3962889
@axw
Member

axw commented Jul 10, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Jul 10, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 269266b into juju:2.2 Jul 10, 2017
1 check passed

1 check passed

github-check-merge-juju Ran tests against PR. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment