Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
When showing or finding offers, ignore those with errors and include store in output #7610
Conversation
| + } | ||
| + store := url.Source | ||
| + if store == "" { | ||
| + store = "local" |
axw
Jul 10, 2017
Member
what does "local" mean in this case? local to the controller that we're querying? what other values might it take on?
wallyworld
Jul 10, 2017
Owner
It's just a label which probably could be improved. Store should never be empty (anymore) so I should just remove this bit.
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit c3d0c37
into
juju:develop
Jul 10, 2017
1 check was pending
github-check-merge-juju
Jenkins queued the run (Commit changed)
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wallyworld commentedJul 10, 2017
Description of change
Some usability tweak to CMR show/find output based on initial user feedback.
QA steps
bootstrap and create offers
find show/find to see new output
delete offered application and find should still work
Bug reference
https://bugs.launchpad.net/juju/+bug/1702901
https://bugs.launchpad.net/juju/+bug/1702899