When showing or finding offers, ignore those with errors and include store in output #7610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
approved these changes
Jul 10, 2017
cmd/juju/crossmodel/showformatter.go
Outdated
| } | ||
| store := url.Source | ||
| if store == "" { | ||
| store = "local" |
There was a problem hiding this comment.
what does "local" mean in this case? local to the controller that we're querying? what other values might it take on?
There was a problem hiding this comment.
It's just a label which probably could be improved. Store should never be empty (anymore) so I should just remove this bit.
wallyworld
force-pushed
the
cmr-find-show-output
branch
from
dba9ee1
to
f814b53
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
wallyworld
force-pushed
the
cmr-find-show-output
branch
from
f814b53
to
12b9e60
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Some usability tweak to CMR show/find output based on initial user feedback.
QA steps
bootstrap and create offers
find show/find to see new output
delete offered application and find should still work
Bug reference
https://bugs.launchpad.net/juju/+bug/1702901
https://bugs.launchpad.net/juju/+bug/1702899