/juju

2.2 presence log tweak #7625

Merged
merged 2 commits into from Jul 11, 2017

Conversation

Reviewers

@wupeka wupeka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jameinel @jujubot @wupeka
@jameinel
Owner

jameinel commented Jul 11, 2017 •
Edited 1 time

Description of change

Tweaks the TRACE level logging for pingbatcher.

  1. Drops the 'pingbatcher has 0 pings to record'. It triggers every 1s for every PingBatcher, which means in an HA controller it writes a message 6 times/second. It isn't very interesting, so we can just drop it, even at TRACE. (3 of those batchers also never have anything to do because they aren't the apiserver backing state object.)
  2. Include the model uuid prefix and drop the 'pingbatcher' wording. This makes TRACE logging look more consistent, and is a little bit easier to follow. (PingBatcher was written to support multiple models at the same time, and I didn't want to give that up, so we just aggregate the model uuids from the docs we're updating.)

QA steps

$ juju model-config logging-config=juju.state.presence=TRACE
$ juju debug-log --include-model juju.state.presence

Should look a little better after these changes. (removal of lots of '0 to record' messages, and better formatting of existing messages.

Documentation changes

None

Bug reference

None

jameinel added some commits Jul 11, 2017

@jameinel
Record model-uuids when writing pings. 
When using TRACE logging on juju.state.presence, we were
already reporting the first 6 chars of model-uuids, this
makes pingbatcher use the same syntax which should make it
nicer to read the logs and correlate what is going on
between pings and pingbatcher.
37c8a13
@jameinel
Change the timestamp to be simply millisecond resolution.
c232fbb
@wupeka

wupeka approved these changes Jul 11, 2017
View changes

lgtm

@jameinel
Owner

jameinel commented Jul 11, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Jul 11, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit fce9a4b into juju:2.2 Jul 11, 2017
1 check passed

1 check passed

github-check-merge-juju Ran tests against PR. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment