Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Introduce state.IAASModel #7667
Conversation
4a6f656c
and others
added some commits
Jul 4, 2017
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit a87ab19
into
juju:develop
Jul 25, 2017
1 check passed
github-check-merge-juju
Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
|
I'd like to see a bit of discussion in the doc comments about exactly what this "IAASModel" is and how it differs from any other Juju model. "Infrastructure as a service" is an very abstract thing - I have no idea from looking at this PR, or glancing through the code what this change is for or what the name actually implies. |
mjs
deleted the
mjs:state-iaasmodel-storage
branch
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mjs commentedJul 25, 2017
•
Edited 1 time
-
mjs
Jul 25, 2017
Description of change
This is the first of a series of changes that moves IAAS specific functionality from
state.Stateonto a newstate.IAASModeltype. This is in preparation for new model types. The idea is thatStatewill only deal with generic functionality with model type specific functionality being available via new types accessible viaState.This change moves everything to do with storage onto a new
IAASModeltype. Future PRs will move more areas of functionality across.QA steps
All unit tests pass. Deploying a simple storage charm works as expected:
Documentation changes
N.A. - internal only.
Bug reference
N.A.